Skip to content

fix(sdk): initialize sandbox annotations#2296

Merged
drew merged 1 commit into
mainfrom
e6f319c-fix-sdk-tests/an
Jul 15, 2026
Merged

fix(sdk): initialize sandbox annotations#2296
drew merged 1 commit into
mainfrom
e6f319c-fix-sdk-tests/an

Conversation

@drew

@drew drew commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the SDK test failures introduced when #1862 merged after the sandbox annotations protobuf changes. The SDK and its mock gateway now initialize the new annotation maps, restoring compilation on main.

Related Issue

Follow-up to #1862 and commit e6f319c.

Changes

  • Initialize CreateSandboxRequest.annotations in the curated SDK client
  • Initialize ObjectMeta.annotations in the mock gateway fixture
  • Assert that curated sandbox creation sends an empty annotations map

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (not applicable)

Additional verification:

  • cargo test -p openshell-sdk
  • mise run test

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; no behavior or architecture change)

The SDK merged after CreateSandboxRequest and ObjectMeta gained annotations on main, leaving stale struct initializers that prevented the crate and its tests from compiling. Initialize the curated request and mock metadata with empty annotation maps.

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew
drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners July 15, 2026 14:59
@drew
drew enabled auto-merge (squash) July 15, 2026 15:07
@drew
drew merged commit 8029321 into main Jul 15, 2026
30 checks passed
@drew
drew deleted the e6f319c-fix-sdk-tests/an branch July 15, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants