Skip to content

Include cuda.core C++ .h files in packages#2236

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/cuda-core-cpp-h-package-data
Open

Include cuda.core C++ .h files in packages#2236
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/cuda-core-cpp-h-package-data

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Include _cpp/*.h in the cuda-core source distribution manifest.
  • Include _cpp/*.h in setuptools package data so wheel builds carry the C++ helper header.

Why

cuda/core/_tensor_map.pyx includes _cpp/tensor_map_cccl.h, but the _cpp packaging metadata only included .hpp headers. Builds from packaged artifacts could miss the required header.

Checks

  • cd cuda_core && uv run --no-project --with build python -m build --sdist --outdir ../cuda-python-package-check
  • tar -tzf ../cuda-python-package-check/cuda_core-*.tar.gz | rg "cuda/core/_cpp/tensor_map_cccl\.h$"
  • cd cuda_core && uv run --no-project --with "setuptools>=80" --with "setuptools-scm[simple]>=8" --with "Cython>=3.2,<3.3" --with "cuda-pathfinder>=1.5" python setup.py build_py --build-lib ../cuda-python-build-py-check
  • test -f ../cuda-python-build-py-check/cuda/core/_cpp/tensor_map_cccl.h
  • git diff --check -- cuda_core/MANIFEST.in cuda_core/pyproject.toml

@copy-pr-bot

copy-pr-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the cuda.core Everything related to the cuda.core module label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant