Skip to content

Update HTTP link to HTTPS - #101

Merged
aritger merged 1 commit into
NVIDIA:mainfrom
alcaparra:patch-2
May 25, 2022
Merged

aritger merged 1 commit into
NVIDIA:mainfrom
alcaparra:patch-2

Conversation

@alcaparra

Copy link
Copy Markdown
Contributor

http://www.nvidia.com redirects to https://www.nvidia.com, so linking to http is reduntant.
More importantly, it could be considered a security issue, do to the nature of plain http. An attacker could perform a MITM attack and redirect the HTTP request to a malicious website.

> GET / HTTP/1.1
> Host: www.nvidia.com

Response:
< HTTP/1.1 307 Temporary Redirect
< Location: https://www.nvidia.com/

http://www.nvidia.com redirects to https://www.nvidia.com/, so linking to http is reduntant.
More importantly, it could be considered a security issue, do to the nature of plain http. An attacker could perform a MITM attack and redirect the HTTP request to a malicious website.
```
> GET / HTTP/1.1
> Host: www.nvidia.com

Response:
< HTTP/1.1 307 Temporary Redirect
< Location: https://www.nvidia.com/
```
@Shinyzenith

Shinyzenith commented May 12, 2022 •

Copy link
Copy Markdown

Redacted

@Technetium1 Technetium1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shinyzenith This is absolutely not spam. It's a very valid PR with good intent. Not only does it provide a legitimate solution, but it describes what the issue is and why it should be considered a problem. This is the definition of legitimate contribution even if it's a rather insignificant change. Telling or implying that someone is spamming because you don't agree with a contribution is almost definitely very offputting to new contributors.

@Shinyzenith

Shinyzenith commented May 12, 2022 •

Copy link
Copy Markdown

@Shinyzenith This is absolutely not spam. It's a very valid PR with good intent. Not only does it provide a legitimate solution, but it describes what the issue is and why it should be considered a problem. This is the definition of legitimate contribution even if it's a rather insignificant change. Telling or implying that someone is spamming because you don't agree with a contribution is almost definitely very offputting to new contributors.

You do make a compelling point. Although this does make some sense it's a pretty pointless patch. I do apologize if I came off rough to new contributors.

-Aakash

@BujuArena

Copy link
Copy Markdown

It's not pointless though. It's legit. The link should use https.

@ghost

ghost commented May 12, 2022 •

Copy link
Copy Markdown

You do make a compelling point. Although this does make some sense it's a pretty pointless patch. I do apologize if I came off rough to new contributors.

-Aakash

Patch? It literally just adds one letter to the end of a few strings. This isn't a patch as it is just basic security. It should've been done when it was first written.

@aritger aritger self-assigned this May 12, 2022
@SeqBra

SeqBra commented May 13, 2022

Copy link
Copy Markdown

@alcaparra Went through and got the rest I could find, See alcaparra#1

@PAR2020 PAR2020 added the Implemented Fixed, in test prior to release integration label May 24, 2022
@aritger
aritger merged commit 570b630 into NVIDIA:main May 25, 2022
@aritger

aritger commented May 25, 2022

Copy link
Copy Markdown
Collaborator

Thanks for the submission; I've merged the specific change in this PR (fixing http://www.nvidia.com/object/quadro-sync.html). And, I've updated the remaining http => https instances within our internal code base. That should show up in a subsequent release.

@PAR2020 PAR2020 added this to the 515.48.07 milestone May 31, 2022
@alcaparra
alcaparra deleted the patch-2 branch July 26, 2022 13:33
@7ERr0r 7ERr0r mentioned this pull request Jan 24, 2024
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Implemented Fixed, in test prior to release integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants