Conversation
When using the Vulkan direct mode with a display that uses a 2Heads1Or (DSC dual head) configuration, the second head's viewport offset defaulted to 0 and was never set to the correct offset. This resulted in the second head fetching the same region as the first, which appears as a duplication of the left part of the display to the right. This commit sets the default offset to the head's merge section instead of always 0.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Vulkan direct mode with a display that uses a 2Heads1Or (DSC dual head) configuration, the second head's viewport offset defaulted to 0 and was never set to the correct offset. This resulted in the second head fetching the same region as the first, which appears as a duplication of the left part of the display to the right.
This commit sets the default offset to the head's merge section instead of always 0.
This issue has been discussed on https://forums.developer.nvidia.com/t/linux-direct-mode-left-eye-image-duplicated-on-both-eyes-with-shiftall-meganex-8k-mark-ii-desktop-mode-works-correctly/381222
The patch has been to confirmed to work with a Pimax Dream Air, which is a 7104×3840 90Hz display, that requires a DSC_DUAL configuration on the 40 series and lower.