Fix Admin MCP OAuth guest 500 (Route [login] not defined) - #513
Merged
Merged
Conversation
Passport guests hit AuthenticationException; Laravel fell back to
route('login') which was undefined. Send oauth/* to Filament admin
login, keep customer.login elsewhere, and name /oauth/login as login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handler::unauthenticatedso OAuth guests redirect to Filament admin login (JSON still 401; other web guests keepcustomer.login)Route::redirect('/oauth/login', '/admin/login')->name('login')soroute('login')resolves without stealing/login/oauth/authorizeredirects to/admin/logininstead of 500Test plan
php artisan test --filter=AdminMcpOAuthTest(12 passed)