Skip to content

add trimSentences option to SentenceTokenizer, to let users choose to preserve whitespace #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hugo-ter-Doest merged 5 commits into from
May 22, 2025
+20 −2
Merged

add trimSentences option to SentenceTokenizer, to let users choose to preserve whitespace #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df1ce49
add trimSentences option to SentenceTokenizer.tokenize()
jeremybmerrill Apr 3, 2025
93acf3b
trimSentence argument is on the SentenceTokenizer constructor, not on…
jeremybmerrill Apr 3, 2025
651fd45
add test for trimSentence
jeremybmerrill Apr 3, 2025
fbd1e1f
Update sentence_tokenizer.js
Hugo-ter-Doest May 21, 2025
90e8e59
Update sentence_tokenizer.js
Hugo-ter-Doest May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/natural/tokenizers/sentence_tokenizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,18 @@ function escapeRegExp (string) {
}

class SentenceTokenizer extends Tokenizer {
constructor (abbreviations) {
constructor (abbreviations, trimSentences) {
super()
if (abbreviations) {
this.abbreviations = abbreviations
} else {
this.abbreviations = []
}
if (trimSentences === undefined) {
this.trimSentences = true
} else {
this.trimSentences = trimSentences
}
this.replacementMap = null
this.replacementCounter = 0
}
Expand Down Expand Up @@ -181,7 +186,7 @@ class SentenceTokenizer extends Tokenizer {
const trimmedSentences = this.trim(newSentences)
DEBUG && console.log('Phase 7: trimming array of empty sentences: ' + JSON.stringify(trimmedSentences))

const trimmedSentences2 = trimmedSentences.map(sent => sent.trim())
const trimmedSentences2 = trimmedSentences.map(sent => this.trimSentences ? sent.trim() : sent)
DEBUG && console.log('Phase 8: trimming sentences from surrounding whitespace: ' + JSON.stringify(trimmedSentences2))
DEBUG && console.log('---End of sentence tokenization--------------------------')
DEBUG && console.log('---Replacement map---------------------------------------')
Expand Down
13 changes: 13 additions & 0 deletions spec/sentence_tokenizer_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,3 +220,16 @@ describe('sentence_tokenizer', function () {
})
})
})

// describe('sentence_tokenizer with trimSentences set to false', function () {
// let tokenizer: Tokenizer

// beforeAll(function () {
// tokenizer = new Tokenizer(['i.e.', 'etc.', 'vs.', 'Inc.', 'A.S.A.P.'],
// ['.', '!', '?', '\n', '\r', '...', '…'], false)
// })

// it('should tokenize strings but not trim whitespace if trimSentences is false', function () {
// expect(tokenizer.tokenize('This is a sentence. This is another sentence.')).toEqual(['This is a sentence. ', 'This is another sentence.'])
// })
// })