Skip to content

Use built-in function to get OIDC token.#5

Open
teo-tsirpanis wants to merge 2 commits into
NuGet:mainfrom
teo-tsirpanis:oidc-simplify
Open

Use built-in function to get OIDC token.#5
teo-tsirpanis wants to merge 2 commits into
NuGet:mainfrom
teo-tsirpanis:oidc-simplify

Conversation

@teo-tsirpanis

Copy link
Copy Markdown

No description provided.

@chabiss chabiss requested a review from Lanaparezanin June 18, 2026 18:29
@Lanaparezanin

Copy link
Copy Markdown
Contributor

These changes are overwriting our error messages, which help publishers debugging, hence I would be hesitant to remove them.

@jozefizso

Copy link
Copy Markdown

These changes are overwriting our error messages, which help publishers debugging, hence I would be hesitant to remove them.

This is a very poor excuse to implement a standards based approach provided by platform maintainer.

@jozefizso

Copy link
Copy Markdown

The custom OIDC implementation here is a nightmare to use as we must get an exception to use this action and periodicaly request the exception.

@teo-tsirpanis

Copy link
Copy Markdown
Author

The toolkit's error messages are defined here, if anyone wants to improve them.

@Lanaparezanin

Copy link
Copy Markdown
Contributor

@jozefizso Thank you for bringing that up, I genuinely didn't know that this was a pain point (that you needed to get exceptions to use it). I raised a PR for improving logs in the toolkit's repo (thanks @teo-tsirpanis for the link) and will test and approve this PR as soon as that one is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants