[IMP] queue_job: Add cancelled state to queue.job#347
Merged
Conversation
guewen
reviewed
May 18, 2021
Member
It looks good to me :) |
0279dd3 to
32dea7b
Compare
Member
Author
|
thanks all, changed according to comments |
Member
|
Were you still going to add a test? |
47ff477 to
5045d6d
Compare
Member
Author
|
now with the promised tests. Anybody have permissions to fix runbot? |
guewen
approved these changes
May 22, 2021
guewen
left a comment
Member
There was a problem hiding this comment.
Thanks!
About runbot, I don't.
Member
|
@hbrunn Can you please resolve the conflicts? Thanks! |
5045d6d to
6299faa
Compare
Member
Author
|
@dreispt thanks for the heads up! |
6a7db7d to
9720915
Compare
Member
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at fab0256. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll add tests when we agree this is how it should work