Skip to content

[18.0][FIX] queue_job: Restore doctesting.#931

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
amh-mw:18.0-doctest
Jun 26, 2026
Merged

[18.0][FIX] queue_job: Restore doctesting.#931
OCA-git-bot merged 1 commit into
OCA:18.0from
amh-mw:18.0-doctest

Conversation

@amh-mw

@amh-mw amh-mw commented Apr 30, 2026

Copy link
Copy Markdown
Member

Fixes #780

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @guewen, @sbidoul,
some modules you are maintaining are being modified, check this out!

@amh-mw amh-mw marked this pull request as ready for review April 30, 2026 19:31
@amh-mw

amh-mw commented Apr 30, 2026

Copy link
Copy Markdown
Member Author

I'm not in love with this. Verbose output is ugly, so I turned it back off, but otherwise it is just a single line in the logs for potentially hundreds of doctests. I was expecting code coverage to increase more, but it looks like it only improved from the deletions in tests.common

@amh-mw amh-mw changed the title [FIX] queue_job: Restore doctesting. [18.0][FIX] queue_job: Restore doctesting. May 18, 2026
@sbidoul

sbidoul commented Jun 26, 2026

Copy link
Copy Markdown
Member

I'm not in love with this. Verbose output is ugly, so I turned it back off, but otherwise it is just a single line in the logs for potentially hundreds of doctests. I was expecting code coverage to increase more, but it looks like it only improved from the deletions in tests.common

It's better than no doctests at all. Thanks for tackling this!

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-931-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 894b603 into OCA:18.0 Jun 26, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 6c0a91a. Thanks a lot for contributing to OCA. ❤️

@amh-mw amh-mw deleted the 18.0-doctest branch July 14, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[18.0] Tests "doctest" are no longer run since Odoo 18

4 participants