[FIX][11.0][web_responsive] Chatter Position#966
Merged
Conversation
yajo
approved these changes
Jun 25, 2018
Member
|
I set as WIP until you say it's ready. Thanks! |
Member
Author
|
Ok.. i think that is fixed... first time that i use this... sorry for the generated issue :/ |
yajo
reviewed
Jun 26, 2018
| ('sided', 'Sided'), | ||
| ], string="Chatter Position", default='normal') | ||
|
|
||
|
|
| type(self).SELF_WRITEABLE_FIELDS.extend(['chatter_position']) | ||
| # duplicate list to avoid modifying the original reference | ||
| type(self).SELF_READABLE_FIELDS = list(self.SELF_READABLE_FIELDS) | ||
| type(self).SELF_READABLE_FIELDS.extend(['chatter_position']) |
Member
There was a problem hiding this comment.
TIL 😃
I think it would be good to add a test for this. It would be so simple as impersonating the demo user and trying to write own field, and read if it got properly written.
Member
|
You have a linter error. |
Member
|
Bah, I fixed it myself. I'll fast-track this if it goes ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix user preferences view... and clean unused variables.
Fix #951 detected issue...