Clear the turn timeout when the turn ends - #130
Merged
Merged
Conversation
…orts a dead child ten minutes later AbortSignal.timeout kept firing after the SDK had removed its child listeners, so any turn ending on an error event crashed the process at the timeout (21:56 UTC restart). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 21:56 UTC restart was a crash: a resident turn ended at 21:46:44 on a stream error, the SDK removed its child-process listeners, and the 600s AbortSignal.timeout fired at 21:56:44 into a child with no error listener. Uncaught AbortError, exit 1, systemd restart. Every turn that ends early on an error event repeats this.
turn() now owns an AbortController and a timer, and clears the timer in finally.
🤖 Generated with Claude Code