Delete the tests and the taste packs - #73
Merged
Merged
Conversation
The packs were not just files: `stupify taste`, `--pack`, the `--yes` default to sindre-sorhus in setup/provision, and the prime installer all read packs/<id>.md out of the package root, and a rubric-only ~/.stupify/.review is invisible to every consumer (they all require CORPUS.md). So the pack feature goes with the files: no `taste` command, no `--pack` flag, no assembleReview. Taste is the repo's own .review/, scaffolded by `stupify init`; ~/.stupify/.review stays as a hand-placed global fallback. Drops the `bun test` steps from CI and release (bun test exits 1 with no test files), `packs` from the published files, the packs section and links from README and the landing page, and the pack wording from prime.ts's corpus trimming (it splits on `---` sections, packs or not).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Noah: delete all tests and packs.
What goes
src/init.test.ts,src/prime-install.test.ts,src/sweep/verdict.test.ts, and thebun teststeps inci.ymlandrelease.yml(bun testexits 1 with zero test files, so the steps had to go with them).packs/*.md(11 files) andpacksfrom the publishedfileslist.Why the CLI changes too
The packs were wired into four flows, not just shipped as files:
stupify taste,--pack, the--yesdefault tosindre-sorhusinsetup/provision(the VM first-boot command passed--pack), and the prime installer. All of them readpacks/<id>.mdfrom the package root, so deleting the files alone would crash every one of them with ENOENT. And a rubric-only~/.stupify/.reviewis invisible to every consumer (hasMachinery,hasTaste, and prime's resolver all requireCORPUS.md), soassembleReviewwithout packs was a no-op.So the feature is removed whole:
tastecommand,--packflag,PACKS,pickPacks,tasteLabel,assembleReview. Taste is the repo's own.review/viastupify init;~/.stupify/.reviewremains as a hand-placed global fallback (the bevyl VMs rely on it and are untouched).Also: README packs section and bullet, the landing page's packs section, nav link, hero links and CSS, and pack wording in
prime.ts(it splits the corpus on---sections regardless).Checks
typecheck, lint, fmt:check,
bun src/cli.ts --help, sweep bundle build, andastro buildall pass. Net: 12 files changed, roughly 290 lines removed fromsrc/and the site, plus the 14 deleted files.