Skip to content

review_verdict is called once, when the review is complete #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Octember merged 1 commit into from
Sep 8, 2026
Merged

review_verdict is called once, when the review is complete #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sweep/codex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export async function runReview(
server.registerTool(
'review_verdict',
{
description: 'Submit your verdict. You may call it again to revise; the last call wins.',
description: 'Submit your verdict once, when your review is complete.',
annotations: { readOnlyHint: true, destructiveHint: false, openWorldHint: false },
inputSchema: ReviewOutput.shape,
},
Expand All @@ -56,7 +56,7 @@ export async function runReview(
}
}
got.verdict = parseReview(data)
return Promise.resolve(text('noted'))
return Promise.resolve(text('recorded. Do not call again unless your verdict changes.'))
},
),
})
Expand Down
2 changes: 1 addition & 1 deletion src/sweep/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ ${corpus}
# This PR
Review this pull request against the spec and rubric.
- Catch bugs, type-lies, dead code, footguns, and slop. Reuse corpus primitives; don't add LOC.
- Submit the verdict by calling \`review_verdict\`; a second pass follows, and you may call it again to revise. Your text is not read.
- When your review is complete, call \`review_verdict\` once. Your text is not read.
- \`fixed\`: prior issues resolved, nothing new (runner posts \`${FIXED_NOTE}\`).
- \`no_new_issues\`: clean, or prior issues still open (runner posts \`${STILL_NOTE}\` if clean).
- \`findings\`: exact path/line for each inline comment, on a line this diff touches.${intent}${memory}
Expand Down