fix: drop unsupported .csv from self-hosted env examples - #417
Open
Frankie-Xu wants to merge 1 commit into
Open
Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
The worker format router has no CSV adapter, and storage.py's SUPPORTED_EXTENSIONS default does not include .csv. The example files advertised it, so Quick Start copies would admit CSV at the API then fail in the worker. Co-authored-by: Frankie-Xu <Frankie-Xu@users.noreply.github.com>
Frankie-Xu
marked this pull request as ready for review
September 14, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to self-hosted Quick Start (
cp apps/api/.env.example apps/api/.envand the worker equivalent).Summary
.csvfromSUPPORTED_EXTENSIONSinapps/api/.env.exampleandapps/worker/.env.example.format_router.SUPPORTED_FILE_TYPES/resolve_document_format()cannot parse.csv(no CSV adapter; it raisesValidationException).storage.pySUPPORTED_EXTENSIONSdefault also omits.csv..csv..csv, so a self-hosted operator following README Quick Start could pass API admission and then hard-fail in the worker.Example-only. No production default, admission behavior, parser, or README change.
Not in this PR (admission-contract gap, needs maintainer decision)
Worker
format_routerand README list.jsonas supported, butstorage.py'sSUPPORTED_EXTENSIONSdefault omits.json. Out-of-the-box (no env override) the API rejects a format the worker can parse. Changing that default is a public admission-behavior change, so it is not included here. Tracked as #418.Verification
make lint— All checks passedmake typecheck— 0 errors, 0 warnings, 0 informationsSUPPORTED_FILE_TYPESstill has no.csvstorage.pydefault still omits.csv.csvDeployment Notes
.csvare unchanged until they recopy the example.Checklist
SUPPORTED_EXTENSIONSdefault unchanged