Skip to content

[csharp][httpclient] do not use deprecated HttpRequestMessage.Properties - #20737

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
ffabss:csharp-fix-warning-deprecated-properties
Oct 21, 2025
Merged

wing328 merged 1 commit into
OpenAPITools:masterfrom
ffabss:csharp-fix-warning-deprecated-properties

Conversation

@ffabss

@ffabss ffabss commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Currently generated code (for recent .Net versions) has warnings because the Api uses HttpRequestMessage.Properties which is deprecated. This PR replaces its usages with HttpRequestMessage.Options.
Additionally some formatting has been changed.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

@wing328
wing328 merged commit 00d1649 into OpenAPITools:master Oct 21, 2025
@wing328

wing328 commented Oct 21, 2025

Copy link
Copy Markdown
Member

thanks for the PR, which has been merged

sorry for the delay in reviewing.

@wing328 wing328 added Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Oct 21, 2025
@wing328 wing328 added this to the 7.17.0 milestone Oct 21, 2025
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants