Skip to content

[scala-sttp4-jsoniter] add generic Option and Seq codecs for jsoniter-scala - #23800

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
reynaldjoabet:scala-sttp4-jsoniter-option-seq-codecs
Jul 31, 2026
Merged

wing328 merged 1 commit into
OpenAPITools:masterfrom
reynaldjoabet:scala-sttp4-jsoniter-option-seq-codecs

Conversation

@reynaldjoabet

@reynaldjoabet reynaldjoabet commented May 17, 2026 •

Copy link
Copy Markdown
Contributor

Add generic JsonValueCodec instances for Option[A] and Seq[A] directly
in JsonSupport, derived via deriveJsonCodec. Without these, the generated
code that wraps types in Option or Seq fails to compile because no implicit
codec is in scope at the call site.

@lbialy @flsh86

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add generic JsonValueCodec for Option[A] and Seq[A] in JsonSupport for scala-sttp4-jsoniter. This fixes compile errors in generated clients when optional or sequence fields are present.

  • Bug Fixes
    • Provide given instances for JsonValueCodec[Option[A]] and JsonValueCodec[Seq[A]] via deriveJsonCodec, ensuring required implicits are always in scope.

Written for commit 8e59584. Summary will update on new commits. Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@wing328

wing328 commented May 18, 2026

Copy link
Copy Markdown
Member

thanks for the PR

cc @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06)

@wing328

wing328 commented May 19, 2026

Copy link
Copy Markdown
Member

@reynaldjoabet are you using this change in your production environment to confirm it works for your use cases?

@wing328

wing328 commented May 20, 2026

Copy link
Copy Markdown
Member

Is there a minimal spec to easily reproduce the issue and confirm the fix?

That will help speed up the review and get it merged sooner

@wing328
wing328 merged commit 7428ad8 into OpenAPITools:master Jul 31, 2026
24 checks passed
@wing328 wing328 added this to the 7.25.0 milestone Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants