Skip to content

fix water template for dry system#19

Merged
lohedges merged 1 commit into
OpenBioSim:develfrom
z-gong:watertemplate
May 25, 2026
Merged

fix water template for dry system#19
lohedges merged 1 commit into
OpenBioSim:develfrom
z-gong:watertemplate

Conversation

@z-gong

@z-gong z-gong commented May 25, 2026

Copy link
Copy Markdown
Contributor

when I use loch to simulate the water absorption into a dry system, which contains no water, the water_template provided causes Exception. it seems the type of the template should be _sr.mol.Molecule, rather than _sr.molecule.Molecule

@lohedges lohedges added the bug Something isn't working label May 25, 2026
@lohedges lohedges self-requested a review May 25, 2026 16:46

@lohedges lohedges left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for catching this! I'll merge and backport the fix to the main branch.

I'd be interested to hear how you get on with your simulations. An issue thread for a similar setup using grand implied that it wasn't possible to hydrate an empty box. (In this case it was just a completely empty box, rather than a dry system.) Presumably favourable binding with a protein / ligand would act as a hydration site.

@lohedges lohedges merged commit b33a8be into OpenBioSim:devel May 25, 2026
@lohedges lohedges mentioned this pull request May 25, 2026
@z-gong z-gong deleted the watertemplate branch May 26, 2026 14:16
@z-gong

z-gong commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

In my case, water molecules gradually filled the cavities in the dry system.

The phenomenon described in essex-lab/grand#14 is somehow simulating the vapor-liquid equilibriation. Considering the low vapor pressure of water at ambient temperature, it's actually reasonable to have less than 1 water molecule in the box.

At 300 K, Pvap​≈3.5kPa
For a 3 nm cubic box, N = PV/kT = 0.023 molecules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants