Improve details - #3794
Draft
EmilyRagan wants to merge 3 commits into
Draft
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3794 +/- ##
==========================================
+ Coverage 79.13% 79.21% +0.08%
==========================================
Files 894 894
Lines 66865 66984 +119
Branches 2551 2600 +49
==========================================
+ Hits 52911 53061 +150
+ Misses 13293 13263 -30
+ Partials 661 660 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
detailsinstead of crashing scriptinterface_detailsto documentation (Claude generated)detailsto "Custom Interfaces" documentationWhy it changed
Support email about custom interface crashing when calling
interface_detailson it, digging deeper into how this function works and what it callsTesting strategy
Ruby and Python unit tests
Review notes
A lot was added to the documentation detailing the return format of
interface_detailswith both common keys and interface-specific keys. They are tabbed so that not all information is shown at once, but it is a lot of lines and still a fairly large section on the docs page. Details about what is returned is a big hole in the documentation, and it is possible that this opens a can of worms, but this feels like one of the most complex returns of methods that are offered to users.