Fix nested resource 404 generation - #91
Merged
Merged
Conversation
|
Issued by Coverage Checker: Coverage ✅ Your code coverage has not been degraded 🎉
∆ 0.056 🟢
|
There was a problem hiding this comment.
Pull request overview
Updates 404 test generation so nested-resource paths invalidate every eligible resource identifier.
Changes:
- Replaces all eligible path parameters with stable schema-valid values.
- Preserves enum and unsupported parameters.
- Expands tests and documentation for nested paths and integer boundaries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Test/Preparator/Error404Preparator.php |
Generates and applies all safe path replacements. |
tests/Preparator/Error404PreparatorTest.php |
Covers nested resources and integer edge cases. |
docs/preparators-config.md |
Documents the new replacement behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dzov
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes the generated 404 case failing in OpenClassrooms/SdZv4#21074 when only the parent lookup returns 404.
Tests: