get rid of inclusion of pf17 inside of unbounded_variant - #126
Conversation
…ion #docs #sonar
| /// C++14 limitation and polyfill optionality (by design in CETL, according to Scott), so a bit of code duplication. | ||
| /// | ||
| template <typename T> | ||
| struct in_place_type_t |
There was a problem hiding this comment.
Can this be a public member of unbounded_variant? ub_var feels like an ugly hack.
pavel-kirienko
left a comment
There was a problem hiding this comment.
If we're going to keep this, should we not alert the user in the doc comments for these constructors that one should consider using the freestanding factory function instead:
CETL/include/cetl/unbounded_variant.hpp
Line 1109 in 4c754a5
CETL/include/cetl/unbounded_variant.hpp
Line 1130 in 4c754a5
CETL/include/cetl/unbounded_variant.hpp
Line 1156 in 4c754a5
CETL/include/cetl/unbounded_variant.hpp
Line 1180 in 4c754a5
So that one does not have to touch the ad-hoc in_place_type
Good idea, I will do this. |
|



No description provided.