Working around GCC7 bug handling temporary template parameters - #183
Merged
Merged
Conversation
- fixes issue/151 - a couple more instances for issues/120 - removing some invalid C++23 cmake presets - removing gcc7 ifdef around variant constexpr This last one is a mystery. It appears the GCC7 constexpr bug was being caused by something else that has since been fixed as we've worked around better understood GCC7 bugs.
thirtytwobits
marked this pull request as ready for review
March 25, 2025 01:50
|
pavel-kirienko
approved these changes
Mar 25, 2025
pavel-kirienko
left a comment
Member
There was a problem hiding this comment.
not sure if removing the Alt alias helped with readability though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This last one is a mystery. It appears the GCC7 constexpr bug was being caused by something else that has since been fixed as we've worked around better understood GCC7 bugs.