Fix for issue/141: cetl::get_if should should match only on a unbounded_variant - #185
Merged
Merged
Conversation
serges147
commented
Apr 10, 2025
serges147
commented
Apr 10, 2025
serges147
commented
Apr 10, 2025
pavel-kirienko
previously approved these changes
Apr 11, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
cetlvast/suites/unittest/test_unbounded_variant.cpp:461
- The expected value for 'src' was changed from '1 + 10' to '1'; please confirm that this behavior change is intentional.
EXPECT_THAT(get<test>(src).value_, 1);
include/cetl/cetl.hpp:132
- The updated conditional for CETL_ENABLE_DEBUG_ASSERT now requires it to be truthy; please ensure that this change aligns with the intended behavior for debug assertions.
#if defined CETL_ENABLE_DEBUG_ASSERT && CETL_ENABLE_DEBUG_ASSERT
serges147
marked this pull request as ready for review
April 14, 2025 08:18
pavel-kirienko
approved these changes
Apr 14, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.