fixing #31, adding move with new alloc ctor - #38
Merged
Merged
Conversation
thirtytwobits
commented
Jun 11, 2023
| std::allocator_traits<std::remove_reference_t<UAlloc>>::is_always_equal::value)> | ||
| {}; | ||
|
|
||
| // +----------------------------------------------------------------------+ |
Member
Author
There was a problem hiding this comment.
This never ended up getting used so it was dead code.
thirtytwobits
commented
Jun 11, 2023
| /// | ||
| using size_type = std::size_t; | ||
|
|
||
| constexpr VariableLengthArrayBase( |
Member
Author
There was a problem hiding this comment.
I had to move this stuff down so it could use some of the functions defined below.
thirtytwobits
commented
Jun 11, 2023
| UAlloc&& rhs, | ||
| typename std::enable_if<std::allocator_traits< | ||
| std::remove_reference_t<UAlloc>>::propagate_on_container_move_assignment::value>::type* = | ||
| typename std::enable_if_t< |
Member
Author
There was a problem hiding this comment.
The changes to enable_if_t was recommended by sonar qube.
|
Kudos, SonarCloud Quality Gate passed! |
skeetsaz
reviewed
Jun 12, 2023
skeetsaz
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.