Adding span to CETL - #5
Merged
Merged
Conversation
The first polyfill class in CETL, span. This commit also establishes some of the infrastructure needed for cetlvast and provides full cetlvast coverage of the new span type.
Member
Author
|
Also, CI isn't setup yet. Once span is in place I'll setup our full suite on github actions. |
emrainey
reviewed
Mar 7, 2023
Closed
Member
Author
|
Updated the C++14 issues but I haven't addressed everything in the review yet. |
thirtytwobits
commented
Mar 9, 2023
Member
Author
|
Okay. we good with this now? |
pavel-kirienko
approved these changes
Mar 12, 2023
serges147
pushed a commit
that referenced
this pull request
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first polyfill class in CETL, span. This commit also establishes some of the infrastructure needed for cetlvast and provides full cetlvast coverage of the new span type.
Reviewers: concentrate on span.h and test_span.cpp. Comments on the cmake stuff are welcome but not required.