Fix trunk-upgrade workflow: run upgrade within trunk-action lifecycle

[Copilot]

Original:
The upgrade job in the Trunk Upgrade workflow fails because it invokes ${TRUNK_PATH} in a later shell step after trunk-action has cleaned up its temp install path. This change moves the upgrade execution into the action step so the binary is still valid when called.

• Root cause

  • trunk-action provisions Trunk in a temporary location and cleans it up at step completion.
  • A subsequent run: "${TRUNK_PATH}" ... step can resolve to a non-existent path (No such file or directory).

• Workflow change

  • Updated .github/workflows/trunk-upgrade.yml to run upgrade via trunk-action input arguments instead of a separate shell step.
  • Kept token wiring on the Trunk step (GITHUB_TOKEN) so upgrade requests remain authenticated.

• Resulting execution model

  • Upgrade now executes inside the same action invocation that owns the Trunk binary lifecycle.
  • Eliminates dependency on cross-step reuse of ephemeral TRUNK_PATH.

- name: Install Trunk CLI
  uses: trunk-io/trunk-action@... # v1.3.1
  with:
    arguments: upgrade -y --include-cli
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Actual:
This pull request updates the Trunk CLI installation step in the .github/workflows/trunk-upgrade.yml workflow to streamline the upgrade process. The main change is moving the Trunk CLI and linters upgrade command into the post-init parameter of the trunk-io/trunk-action, eliminating the need for a separate upgrade step.

Workflow improvements:

• .github/workflows/trunk-upgrade.yml: Moved the Trunk CLI and linters upgrade command to the post-init parameter of the trunk-io/trunk-action step, and removed the separate upgrade step. This simplifies the workflow and ensures upgrades happen immediately after installation.

[Morgy93]

@copilot please rebase

[Copilot]

@copilot please rebase

Updated with latest main and resolved the workflow conflict in commit dc9a698, while keeping the Trunk upgrade fix in place.

[Copilot]

Pull request overview

This PR aims to fix the scheduled “Trunk Upgrade” workflow by ensuring the Trunk binary is invoked while it still exists (i.e., within the lifecycle of trunk-io/trunk-action), avoiding failures caused by ${TRUNK_PATH} pointing to a cleaned-up temp install.

Changes:

• Moves the intended trunk upgrade -y --include-cli execution into the trunk-io/trunk-action step configuration (instead of a later shell step).
• Removes the separate shell step that invoked "${TRUNK_PATH}" ... after the action finished.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.