release: the openipc.org push succeeds on a 200 and nothing else - #226
Merged
Merged
Conversation
curl -f fails only on 400 and above. After #225 the push got nginx's 302 to openipc.org's home page (the endpoint had no location yet) and the step reported success. It now checks for 200, prints the answer, and fails visibly otherwise; continue-on-error still keeps it from failing the build.
PR Summary by QodoRequire HTTP 200 for openipc.org release pushes
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #225.
curl -ffails only on status 400 and above. The first push after #225 got a 302 to openipc.org's home page, because the endpoint had no nginx location yet (OpenIPC/website follow-up). The step reported success anyway.This change makes the step require a 200, print openipc.org's answer, and fail visibly on anything else.
continue-on-errorstill keeps a failed push from failing the build.