Skip to content

release: the openipc.org push succeeds on a 200 and nothing else - #226

Merged
openipc-ai merged 1 commit into
masterfrom
tools-push-check-status
Sep 29, 2026
Merged

openipc-ai merged 1 commit into
masterfrom
tools-push-check-status

Conversation

@openipc-ai

Copy link
Copy Markdown
Contributor

Follow-up to #225.

curl -f fails only on status 400 and above. The first push after #225 got a 302 to openipc.org's home page, because the endpoint had no nginx location yet (OpenIPC/website follow-up). The step reported success anyway.

This change makes the step require a 200, print openipc.org's answer, and fail visibly on anything else. continue-on-error still keeps a failed push from failing the build.

curl -f fails only on 400 and above. After #225 the push got nginx's 302 to
openipc.org's home page (the endpoint had no location yet) and the step
reported success. It now checks for 200, prints the answer, and fails
visibly otherwise; continue-on-error still keeps it from failing the
build.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Require HTTP 200 for openipc.org release pushes

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Reject redirects and other non-200 responses that previously appeared to be successful pushes.
• Print the server response and annotate failures without failing the overall build.
Diagram

graph TD
  A["Push step"] --> B["openipc.org API"] --> C["Print response"] --> D{"Status 200?"}
  D -->|Yes| E["Push succeeds"]
  D -->|No| F["Advisory failure"]
Loading
High-Level Assessment

The explicit status check fits the requirement: curl -f does not reject redirects, and the workflow already makes this push advisory. No additional HTTP tooling is warranted.

Files changed (1) +9 / -2

Bug fix (1) +9 / -2
release.ymlRequire HTTP 200 from the openipc.org push endpoint +9/-2

Require HTTP 200 from the openipc.org push endpoint

• Captures the PUT response body and status, prints the body, and emits a GitHub Actions error for any status other than 200. The step retains continue-on-error, so a rejected push does not fail the build.

.github/workflows/release.yml

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@openipc-ai
openipc-ai merged commit cca1ac5 into master Sep 29, 2026
5 checks passed
@openipc-ai
openipc-ai deleted the tools-push-check-status branch September 29, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant