Offer the build's tarballs for download in the firmware explorer - #384
Merged
Merged
Conversation
The explorer showed what a build measured but gave no way to fetch it. The report endpoint now lists the tarballs the build published for the platform, each with its size, SHA-256 and the address in the build's own dated release, so an older nightly links to its own files rather than the newest: - firmware: openipc.<board>-<storage>-<edition>.tgz for the report's board and variant; - builder: <device>-<storage>.tgz for the device, matched exactly, so a device whose name prefixes another's is not offered the other's. The summary shows them as a row of links under the size facts.
PR Summary by QodoOffer build-specific tarballs in the firmware explorer
AI Description
Diagram
High-Level Assessment
Files changed (10)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firmware explorer showed what a build measured but gave no way to fetch it.
GET /api/v1/explorer/{source}/builds/{build}/platforms/{platform}now carriesdownloads: the tarballs the build published for the platform, with size, SHA-256, storage and the GitHub address in the build's own dated release (so an old nightly links to its own files).openipc.<board>-<storage>-<edition>.tgzfor the report's board and variant (build_assets.board/edition);<device>-<storage>.tgz, device matched exactly —…-ipc-1is not offered…-ipc-1-w's.These are release tarballs (kernel + rootfs); full flash images remain the installer's, for the newest build only.
Verification
service/run.sh testpasses; the explorer round trip checks the firmware link, and a new test covers builder's prefix case.npm test601/609 — the 8 failures are the club component tests (localStorageundefined), which fail identically on master under the local Node v26.