chore(release): 0.10.5 - #275
Closed
client-software-ci wants to merge 1 commit into
Closed
Conversation
Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com>
|
Contributor
|
Empty change log. No release needed. Closing. |
1 task
mwiebe
pushed a commit
that referenced
this pull request
Aug 4, 2026
LoggingSubprocess created its Popen with encoding="utf-8" but no errors= parameter, so decoding defaulted to strict. A single byte of subprocess output that is not valid UTF-8 (for example a Windows DCC application writing cp1252, such as Unreal Engine emitting the 0x97 em dash) raised UnicodeDecodeError inside the _enqueue_stdout reader thread. The thread died silently, and all subsequent stdout from the subprocess was lost, masking any later errors from the job. Decode with errors="backslashreplace" so undecodable bytes are escaped (e.g. b"\x97" -> "\\x97") instead of raising. This keeps the reader thread alive while preserving the original byte values in the logs, which helps identify the codepage the subprocess is emitting. This ports the fix that openjd-adaptor-runtime-for-python applied to its own LoggingSubprocess in PRs #275 and #277. Regression tests cover: the reader thread surviving undecodable bytes, escape formatting for single/consecutive/truncated invalid sequences, valid multi-byte UTF-8 passing through unescaped, the behavior under a non-default encoding, and the errors= kwarg on the Popen construction shared by the sudo and Windows-as-user paths. Every test was mutation-checked: removing the errors= parameter, substituting replace/ignore handlers, and forcing an ASCII encoding each fail at least one test. Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.10.5 (2025-09-29)