Fails to compile on SPARC unless TARGET=SPARC is set

[jdemeyer]

On SunOS xenos-sagetest 5.11 11.3 sun4v sparc sun4v with GCC 5.4.0:

getarch_2nd.c: In function 'main':
getarch_2nd.c:12:35: error: 'SGEMM_DEFAULT_UNROLL_M' undeclared (first use in this function)
     printf("SGEMM_UNROLL_M=%d\n", SGEMM_DEFAULT_UNROLL_M);
                                   ^
getarch_2nd.c:12:35: note: each undeclared identifier is reported only once for each function it appears in
getarch_2nd.c:13:35: error: 'SGEMM_DEFAULT_UNROLL_N' undeclared (first use in this function)
     printf("SGEMM_UNROLL_N=%d\n", SGEMM_DEFAULT_UNROLL_N);
                                   ^
getarch_2nd.c:14:35: error: 'DGEMM_DEFAULT_UNROLL_M' undeclared (first use in this function)
     printf("DGEMM_UNROLL_M=%d\n", DGEMM_DEFAULT_UNROLL_M);
                                   ^
getarch_2nd.c:15:35: error: 'DGEMM_DEFAULT_UNROLL_N' undeclared (first use in this function)
     printf("DGEMM_UNROLL_N=%d\n", DGEMM_DEFAULT_UNROLL_N);
                                   ^
getarch_2nd.c:19:35: error: 'CGEMM_DEFAULT_UNROLL_M' undeclared (first use in this function)
     printf("CGEMM_UNROLL_M=%d\n", CGEMM_DEFAULT_UNROLL_M);
                                   ^
getarch_2nd.c:20:35: error: 'CGEMM_DEFAULT_UNROLL_N' undeclared (first use in this function)
     printf("CGEMM_UNROLL_N=%d\n", CGEMM_DEFAULT_UNROLL_N);
                                   ^
getarch_2nd.c:21:35: error: 'ZGEMM_DEFAULT_UNROLL_M' undeclared (first use in this function)
     printf("ZGEMM_UNROLL_M=%d\n", ZGEMM_DEFAULT_UNROLL_M);
                                   ^
getarch_2nd.c:22:35: error: 'ZGEMM_DEFAULT_UNROLL_N' undeclared (first use in this function)
     printf("ZGEMM_UNROLL_N=%d\n", ZGEMM_DEFAULT_UNROLL_N);
                                   ^
make[2]: *** [Makefile.prebuild:58: getarch_2nd] Error 1

In case it helps, this is my config.h:

#define OS_SUNOS        1
#define ARCH_SPARC      1
#define C_GCC   1
#define __64BIT__       1
#define PTHREAD_CREATE_FUNC     pthread_create
#define BUNDERSCORE     _
#define NEEDBUNDERSCORE 1
#define V9
#define DTB_DEFAULT_ENTRIES 32

Building with an explicit TARGET=SPARC works.

[martin-frbg]

Sparc detection gets tested once in a blue moon I guess. As your config.h is probably from the successful case (after giving an explicit target), can you post the output of ./getarch 1 please ?

[jdemeyer]

As your config.h is probably from the successful case

No, it's from the broken case. What fails is compiling getarch_2nd.c, so I do have a config.h.

can you post the output of ./getarch 1 please ?

$ ./getarch 1
#define V9
#define DTB_DEFAULT_ENTRIES 32

[jdemeyer]

For completeness, with TARGET=SPARC, config.h becomes

#define OS_SUNOS        1
#define ARCH_SPARC      1
#define C_GCC   1
#define __64BIT__       1
#define PTHREAD_CREATE_FUNC     pthread_create
#define BUNDERSCORE     _
#define NEEDBUNDERSCORE 1
#define SPARC
#define V9
#define L1_DATA_SIZE 65536
#define L1_DATA_LINESIZE 64
#define L2_SIZE 1572864
#define L2_LINESIZE 64
#define DTB_SIZE 8192
#define DTB_DEFAULT_ENTRIES 64
#define CORE_sparc
#define CHAR_CORENAME "sparc"
#define GEMM_MULTITHREAD_THRESHOLD      4

The crucial difference seems to be #define SPARC which is missing from the auto-generated config.h.

[martin-frbg]

As far as I can tell this should have come from cpuid_sparc.c (which is not really doing any detection), and should have been on the first line of the getarch 1 output. At least adding it to the get_cpuconfig
function in cpuid_sparc.c should not hurt - either get_architecture was used to create this line in the (distant) past, or this was always wrong and nobody bothered to report.