Use C kernels for x86_64 SUM on Windows - #2887
Closed
martin-frbg wants to merge 3 commits into
Closed
martin-frbg wants to merge 3 commits into
martin-frbg wants to merge 3 commits into
Conversation
to work around Win10.19041 fpu bug
Contributor
|
My local build failed, any ideas ? |
Collaborator
Author
|
Looks like you are missing the addition to cmake/system.cmake (bb74dd2 - sorry for not going through the PR mechanism with that one but it was a late night fix for a merge conflict) |
Contributor
|
No cookie. I still get the same errors as in #2882. Is there a more systematic way to do this? |
Collaborator
Author
|
hm strange. The other fpu-using .S files are all unused AFAICT, perhaps the uncleared exception is now triggered by something in gfortran's compilation of the lapack code. |
Collaborator
Author
|
btw this PR is likely to be obsolete as soon as #2888 gets merged. Now all we need is a decent reimplementation of nrm2 and OpenBLAS is going to be just another hapless victim of the Windows bug. :-/ |
… generic C c/zSUM on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second part of workaround for #2709