Fix PrinterSpooler D-Bus signal spoofing - #1691
Merged
Merged
Conversation
The existing policy grants root permission to send messages on the com.redhat.PrinterSpooler interface, but does not deny unprivileged clients. Since the system bus permits broadcast signals by default, an ordinary user can emit a spoofed PrinterSpooler signal despite the comment claiming that only root can send it. Deny signals on this interface in the default policy and allow them again for root. This preserves reception for all connections and limits the change to signal messages, avoiding an unintended restriction on other message types.
michaelrsweet
added a commit
that referenced
this pull request
Sep 2, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to reproduce this locally with a regular, non-root user.
Even though cups.conf says that only root can send the message, the
following command succeeds and is visible to listeners:
dbus-send --system --type=signal /com/redhat/PrinterSpooler com.redhat.PrinterSpooler.PrinterAdded string:fakeIt looks like the current rule only allows root, but does not explicitly
deny anyone else. Since the system bus allows broadcast signals by
default, regular users can spoof these notifications too.