fix(windows): tool launcher shims never fall back to starting the viewer - #75
Merged
Merged
Conversation
When the launcher runs as a tool shim (utvio.exe, py-interp.exe, ...) and can't find the tool's real binary, it fell through to the default target, utv-bin.exe. A tool invoked by a script -- e.g. the startup update check running py-interp.exe -- then opened another viewer, which ran the script again: the endless relaunch in #73 (there caused by an installer/release mismatch, fixed in #74). Report the missing <tool>-bin.exe (stderr, plus a message box when there is no console) and exit instead. Refs #73 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Michael Oliver <mcoliver@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defense in depth for #73 (root cause fixed in the installer, #74).
When the Windows launcher runs as a tool shim (
utvio.exe,py-interp.exe, …) and can't find<tool>-bin.exe, it fell through to the default target,utv-bin.exe. A tool invoked by a script, such as the startup update check runningpy-interp.exe, then opened another viewer, which ran the script again: an endless relaunch.Now it reports the missing binary (to stderr, plus a message box when there's no console) and exits with code 1.
Windows-only code; verified by the Windows CI build.
🤖 Generated with Claude Code