fix(macos): show launcher dialogs when started through LaunchServices - #89
Merged
Merged
Conversation
`open UTV.app` from a shell passes the shell's TERM to the app, so the launcher took it for a terminal launch and printed its missing-dependency and library-mismatch messages to a stderr nobody sees. Treat a launch whose stderr is a non-tty character device (/dev/null, as LaunchServices sets it) as a GUI launch. Refs #85 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Michael Oliver <mcoliver@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open UTV.appfrom a shell passes the shell'sTERMto the app. The launcher took that for a terminal launch and printed its missing-dependency and library-mismatch messages (#88) to a stderr nobody sees, so the app still just disappeared.A launch whose stderr is a non-tty character device (
/dev/null, which is what LaunchServices sets) is now treated as a GUI launch and gets the dialog. Launches from a terminal, or with stderr piped or redirected to a file, still print the message.Verification
A copy of 2026.9 (built against OpenColorIO 2.5) with this launcher, on a Mac with OpenColorIO 2.6.0:
UTV could not load opencolorio 2.6.0and the fix command;open -n UTV.appfrom a shell: the launcher stays up in its dialog (before this change it exited at once with no window);Refs #85
🤖 Generated with Claude Code