test(coaching): follow the photo + LP-as-image branches into the shared media resolver (bd-2kxxa.2) - #574
Merged
Merged
Conversation
…o the shared media resolver (bd-2kxxa.2)
Two root suites still described the pre-R165 inline shape of the image handler:
the bd-2636 source guard looked for the widened status filter inside the handler
(it now lives in media-session-resolver, which the handler delegates to), and the
FEAT-106 idempotency test stubbed supabase for a single .eq('status') lookup and
mocked the processor without handleLessonPlanResponse, which the shared attach
path calls. Both keep asserting the same contracts: the widened filter is used,
and a redelivered LP image is processed exactly once.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 62dae95)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #557. Two root suites still described the pre-R165 inline shape of the image handler and started failing on develop after that merge (they are in the root test tree, which the bot-folder runs did not cover):
bd2636-classroom-photo-statusguarded the widened status filter inside the image handler; it now lives inmedia-session-resolver, which the handler delegates to. The guard now checks both the delegation and the resolver.feat106-image-idempotencystubbed supabase for a single.eq('status')lookup and mocked the processor withouthandleLessonPlanResponse, which the shared attach path calls. The stub now answers the resolver's list query and the mock mirrors the real processor (upload + queue), so the contract — a redelivered LP image is processed exactly once — is still what is asserted.Root
tests/coachingon this branch: 21 failing suites vs 23 on develop; the two that flip are these, everything else identical (pre-existing).🤖 Generated with Claude Code