feat(images): content-appropriate instructional diagrams (R33) + Addition multigrade LP - #24
Open
Zunaira-Shahid1 wants to merge 1 commit into
Open
feat(images): content-appropriate instructional diagrams (R33) + Addition multigrade LP#24Zunaira-Shahid1 wants to merge 1 commit into
Zunaira-Shahid1 wants to merge 1 commit into
Conversation
…tion multigrade LP - R33: match the picture to the content — clean flat-vector infographics for maths concepts (place-value staircase, grouping bundles, number line, column addition), and EXACT numbers/grids go in code (table/math, R14) not AI (which drifts on digits). Wired via a cleaner DIAGRAM_STYLE scaffold and structurer rules that route exact content to table/math. - placeValueTables now detects a place-value/column grid by its VALUE shape (keys are place names) rather than the wrapping key name, so board-prep 'column_setup' charts also become tables. - Demo: multigrade Addition (Grade 4+5) — banner, teacher-here/own duos, rotation schedule, two board-prep place-value tables, and an inline place-value-addition concept diagram. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the multigrade guide (merged in #23).
What's new
tablesection, ormath/ inlineDIAGRAM_STYLEscaffold and structurer rules that route exact content to table/math.placeValueTablesnow recognises a place-value / column grid by its keys being place names (Ones…Hundred Thousands), regardless of the wrapping key — socolumn_setupcharts also render as tables.Demo
assets/generated/lessons/addition-putting-numbers-together.en.*— multigrade Addition (Grade 4+5): banner, teacher-here/on-its-own duos, rotation schedule, two board-prep place-value tables, and an inline place-value-addition concept diagram (regrouping), 0 images dropped.Tests
npm run test:visual100%; imagegen suite green.🤖 Generated with Claude Code