Fix crash/incorrect block rotation when placing computer case or screen on sideways sable sublevels - #98
Merged
CaitlynMainer merged 1 commit intoSep 13, 2026
Conversation
…en on sideways sable sublevel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code responsible for block placement on sable sublevels does not handle sideways sublevels. This can result in a crash, as the game can try to assign an invalid value to the direction of screens or computer cases.
This small PR fixes that, and also make the value properly checked before trying to assign them.
Instead of trying to rotate the facing direction, the new implementation now rotates the players's forward and side vector, and then try to interpret that as a pitch and yaw. Side vector is used as a failsafe for when the forward vector is aligned with the Y axis.
I did need to add a couple functions to the Sable integration, I made sure to update the code comments accordingly.
If you want me to change anything let me know, Scala isn't a language I usually program with so I might have missed a couple things.
Also no AI was used in any of this