Skip to content

fix(ci): tslib 声明 + Caddy 编译错误，一次性让 PR Checks 转绿 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suantea wants to merge 2 commits into from
Closed

fix(ci): tslib 声明 + Caddy 编译错误，一次性让 PR Checks 转绿 #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74998d9
fix(ci): 显式声明 tslib，修复 npm ci 下前端构建失败
suantea Sep 30, 2026
1bdefee
fix(caddy): 修复 buildOIDCRoutes 传 nil 给值类型形参导致编译失败
Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/service/caddy/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,11 @@ func isLocalOrIP(domain string) bool {
func (m *Manager) buildOIDCRoutes(hostMatchers []interface{}, mainHandlers []interface{}, rule model.AccessRule) []interface{} {
providerID := rule.OidcProviderID
if providerID == 0 {
return m.buildPageLoginRoutes(hostMatchers, mainHandlers, nil)
// 未绑定 OIDC provider 时退回页面跳转登录。
// 传空的 AccessRule 而非 nil：buildPageLoginRoutes 的形参是值类型，
// 且 AllowedUserIDs 为空正好表示"不限定可登录用户"，
// 与该分支的语义一致（provider 缺失时无法按 provider 限定用户）。
return m.buildPageLoginRoutes(hostMatchers, mainHandlers, model.AccessRule{})
}
var provider model.OAuthProviderConfig
if err := m.db.First(&provider, providerID).Error; err != nil {
Expand Down
1 change: 1 addition & 0 deletions webpage/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions webpage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"react-dom": "^18.2.0",
"react-i18next": "^13.5.0",
"react-router-dom": "^6.20.0",
"tslib": "^2.8.1",
"xterm": "^5.3.0",
"xterm-addon-fit": "^0.8.0",
"xterm-addon-web-links": "^0.9.0",
Expand Down
Loading