Skip to content

Replace Old with Legacy for ASB#1545

Merged
danielmarbach merged 3 commits into
developfrom
transport-naming
Dec 20, 2018
Merged

Replace Old with Legacy for ASB#1545
danielmarbach merged 3 commits into
developfrom
transport-naming

Conversation

@danielmarbach

Copy link
Copy Markdown
Contributor

No description provided.

@danielmarbach
danielmarbach requested review from a team and tmasternak December 19, 2018 15:52
@danielmarbach

Copy link
Copy Markdown
Contributor Author

I'm guessing with the constants I don't need to change the matching rule to incorporate the previous name right? Because in the settings we store the customization and nothing else correct?

@SeanFeldman

Copy link
Copy Markdown
Contributor

I have looked around to find any use of (Old) in powershell, but couldn't find any other location other than the edited file. Approving API.

@SeanFeldman

Copy link
Copy Markdown
Contributor

@Particular/servicecontrol-maintainers this hint is very confusing:

//HINT: Those names are used in PowerShell scripts thus constitute a public api

Do you have any idea what is it?

@danielmarbach
danielmarbach merged commit 43442d5 into develop Dec 20, 2018
@danielmarbach
danielmarbach deleted the transport-naming branch December 20, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants