Handling large number of message type in endpoint details#719
Merged
Conversation
tmasternak
force-pushed
the
message-type-pagination
branch
from
February 25, 2019 10:04
620bc91 to
5030b68
Compare
Contributor
|
@WilliamBZA ready to review |
WilliamBZA
requested changes
Mar 1, 2019
Member
Author
|
@WilliamBZA review fixes in places. Back to you. |
WilliamBZA
approved these changes
Mar 6, 2019
Contributor
|
I changed the way how js tests are run, if a build would kick in and fail please rebase this PR on top of master which contains the necessary changes for build to pass |
tmasternak
force-pushed
the
message-type-pagination
branch
from
March 8, 2019 11:05
e3f28f7 to
226f9e5
Compare
Member
Author
|
@WojcikMike the PR has been rebased on top of master |
WilliamBZA
pushed a commit
that referenced
this pull request
Feb 17, 2023
Handling large number of message type in endpoint details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR provides browser-side paging for the message types table in endpoint details view. Specifically, it adds:
NOTE: this includes updating angular-ui-bootstrap to 2.5.6 in order to get desired behavior of the pager. I've checked the other places we use the package (tooltips and modals) and they look fine after update.