Skip to content

Buy similar: fix mod matching and improve search workflow#9857

Open
vaisest wants to merge 7 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-tab-market-search-fixes
Open

Buy similar: fix mod matching and improve search workflow#9857
vaisest wants to merge 7 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-tab-market-search-fixes

Conversation

@vaisest

@vaisest vaisest commented May 17, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This PR removes the need to manually generate the URL and reworks the mod matching. Both of these features are ported over from PoB2.

This also contains tradehash fixes for mods.lua. These aren't actually used here now, but they should still be ported over since it will be necessary for the trader, and in general should just be corrected

Steps taken to verify a working solution:

  • Lots of manual testing. There is an insane amount of items that can break this, but I've tried to test a large variety.
  • Automated tests ported

Link to a build that showcases this PR:

https://pobb.in/mFd6odfh1yun (has many items and some that use dropdowns on the trade site.

Before screenshot:

image image

After screenshot:

image image

@vaisest vaisest force-pushed the comparison-tab-market-search-fixes branch from 68e4750 to a3c464b Compare May 18, 2026 10:13
@vaisest vaisest changed the base branch from dev to fix_compare-visuals May 18, 2026 10:13
@vaisest vaisest changed the title Port matching by tradehash in comparison buy similar menu Buy similar: fix mod matching and improve search workflow May 19, 2026
@vaisest vaisest marked this pull request as ready for review May 19, 2026 02:11
@vaisest

vaisest commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Notably, crucible mods aren't matched. This probably doesn't matter much because standard, but regardless in the future it can be added once there's an easier way to match mods. The trade site specifically matches against crucible mods, and not just single stats

@vaisest vaisest force-pushed the comparison-tab-market-search-fixes branch 3 times, most recently from 0743852 to 8b22835 Compare May 27, 2026 16:26
@vaisest vaisest changed the base branch from fix_compare-visuals to dev May 27, 2026 16:26
@vaisest vaisest force-pushed the comparison-tab-market-search-fixes branch from 8b22835 to 520d030 Compare May 27, 2026 16:28
@vaisest vaisest marked this pull request as draft June 29, 2026 15:34
@vaisest vaisest force-pushed the comparison-tab-market-search-fixes branch 2 times, most recently from 127ba5f to 4d3ba04 Compare June 30, 2026 15:59
@vaisest

vaisest commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

This now has all (hopefully) of the PoB2 buy similar stuff. That is, the refactored mod matching, UI which auto generates the URL, and a button for the popup in the items tab

@vaisest vaisest force-pushed the comparison-tab-market-search-fixes branch from 586e73e to 4d3ba04 Compare June 30, 2026 16:21
@vaisest vaisest marked this pull request as ready for review June 30, 2026 19:24
Comment thread src/Export/Scripts/mods.lua Outdated
Comment thread src/Export/Scripts/mods.lua Outdated
Comment thread src/Export/Scripts/mods.lua Outdated
@vaisest vaisest force-pushed the comparison-tab-market-search-fixes branch from 01a9108 to dd5ed5d Compare July 1, 2026 08:49
@vaisest

vaisest commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

This also ports PathOfBuildingCommunity/PathOfBuilding-PoE2#2339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants