Buy similar: fix mod matching and improve search workflow#9857
Open
vaisest wants to merge 7 commits into
Open
Conversation
68e4750 to
a3c464b
Compare
Contributor
Author
|
Notably, crucible mods aren't matched. This probably doesn't matter much because standard, but regardless in the future it can be added once there's an easier way to match mods. The trade site specifically matches against crucible mods, and not just single stats |
0743852 to
8b22835
Compare
8b22835 to
520d030
Compare
127ba5f to
4d3ba04
Compare
Contributor
Author
|
This now has all (hopefully) of the PoB2 buy similar stuff. That is, the refactored mod matching, UI which auto generates the URL, and a button for the popup in the items tab |
586e73e to
4d3ba04
Compare
Nightblade
suggested changes
Jul 1, 2026
01a9108 to
dd5ed5d
Compare
Contributor
Author
|
This also ports PathOfBuildingCommunity/PathOfBuilding-PoE2#2339 |
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR removes the need to manually generate the URL and reworks the mod matching. Both of these features are ported over from PoB2.
This also contains tradehash fixes for mods.lua. These aren't actually used here now, but they should still be ported over since it will be necessary for the trader, and in general should just be corrected
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/mFd6odfh1yun (has many items and some that use dropdowns on the trade site.
Before screenshot:
After screenshot: