fix(runtime): hide WeakRef/WeakMap/WeakSet/FinalizationRegistry internal slots (#1766) - #2267
Merged
Merged
Conversation
…nal slots (#1766) The runtime wrappers for `WeakRef`, `WeakMap`, `WeakSet`, and `FinalizationRegistry` stored their backing data under user-visible field names (`target`, `entries`, `callback`). Reading those fields from user code via `(wr as any).target` / `(wm as any).entries` returned the internal storage slot instead of `undefined` like Node, leaking the `[key, value]`-pair array out of the weak-collection abstraction. Rename all four shapes' internal slots to `__perry_*` sentinels so property reads land on undefined and the inspect-output / functional methods continue to work through the same internal accessors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target,entries,callback). User code reading(wr as any).targetor(wm as any).entriesreturned the raw internal slot (the[key,value]-pair array, the WeakRef target, the cleanup callback) instead ofundefinedlike Node — the weak-wrapper abstraction leaked.__perry_*sentinels (__perry_wr_target,__perry_wk_entriesshared by WeakMap/WeakSet,__perry_fr_callback+__perry_fr_entries) so the user-level property reads land onundefined. The internal accessors (entries_array,js_weakref_deref,js_finreg_register/_unregister) use the same sentinels so functional methods stay byte-identical with Node.Test plan
test-files/test_issue_1766_weakref_internal_fields.tsbyte-identical with Node — covers the leak surface for all four wrapper kinds plus a positive functional round-trip per kind.test_gap_weakmap_dynamic.tsandtest_gap_weakref_finalization.tsparity tests still byte-identical with Node (no regression).cargo fmt --all -- --checkclean.cargo test --release -p perry-runtime --lib— 736 tests pass.