Skip to content

fix(hir): emit computed-key static fields that have no initializer #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Jul 5, 2026
Merged

fix(hir): emit computed-key static fields that have no initializer #6025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/perry-hir/src/lower_decl/static_init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,18 @@ pub(crate) fn build_interleaved_static_init_stmts(
static_methods: &[Function],
) -> Vec<Stmt> {
let emit_field = |out: &mut Vec<Stmt>, sf: &ClassField| {
let Some(init) = &sf.init else { return };
// A COMPUTED-key static field with no initializer still performs
// CreateDataProperty(F, key, undefined) at class-eval time, so it must
// be emitted (value = undefined) rather than dropped: (1) the key
// expression has observable side effects, and (2) a key that evaluates
// to "prototype" is a TypeError (test262 fields-computed-name-static-
// *propname-prototype). A NON-computed uninit static field is a plain
// named slot and keeps the pre-existing "skip when no init" behavior.
if sf.init.is_none() && sf.key_expr.is_none() {
return;
}
// `this` in a static field initializer is the class constructor.
let mut init_value = init.clone();
let mut init_value = sf.init.clone().unwrap_or(Expr::Undefined);
crate::analysis::substitute_lexical_this_in_expr(
&mut init_value,
&Expr::ClassRef(class_name.to_string()),
Expand Down
Loading