fix(runtime): permit catchable throw bridges to unwind - #8869
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe runtime marks catchable unresolved-global and constructor errors as ChangesRuntime throw ABI
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change allows specified runtime throw bridges to unwind catchably and strengthens regression-test failure reporting. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the runtime fix, affected functions, regression evidence, validation steps, and release impact. It does not follow the required template because it omits the Changes, Related issue, Test plan, and Checklist sections. Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
C-unwindcheck(#5249) #5253 regression harness surface child-process abortsRelease evidence
Release-candidate CI run 32988311861 reached
issue_5253_construct_reference_source_locationafter the #5247 value-call tests passed. All four #5253 cases produced empty stdout because their child binaries aborted before the JavaScript catch handlers ran. Both failing runtime entry points were plainextern "C"even though they calljs_throw; this applies the same direct-boundary fix validated by the preceding #5247 test.Validation
cargo fmt --all -- --checkgit diff --checkextern "C-unwind"ABI guardsRelease blocker for v0.5.1519.
Summary by CodeRabbit