deps(deps): Bump jni from 0.21.1 to 0.22.4 - #9454
Conversation
|
Holding this one, and the reasoning is worth recording because no gate anywhere will catch what's wrong with it. jni 0.21→0.22 is a breaking release, and this PR carries no code migration. And the failure would be silent. I tried to validate locally and cannot: the crate is What would let this land: the API migration in |
Bumps [jni](https://github.com/jni-rs/jni-rs) from 0.21.1 to 0.22.4. - [Release notes](https://github.com/jni-rs/jni-rs/releases) - [Changelog](https://github.com/jni-rs/jni-rs/blob/master/CHANGELOG.md) - [Commits](jni-rs/jni-rs@v0.21.1...v0.22.4) --- updated-dependencies: - dependency-name: jni dependency-version: 0.22.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
57f2c58 to
14c9d79
Compare
|
Update, with measurement replacing the inference above — and one correction to my own comment. The correction: "I cannot validate locally" was wrong. This host has an NDK at
So the earlier prediction is now a measured fact: merging this without a migration would break the Android leg, and silently — A migration is now in progress on a branch, using the working cross-check as its verification loop, with the constraint that the 44 |
* deps(deps): Bump jni from 0.21.1 to 0.22.4 Bumps [jni](https://github.com/jni-rs/jni-rs) from 0.21.1 to 0.22.4. - [Release notes](https://github.com/jni-rs/jni-rs/releases) - [Changelog](https://github.com/jni-rs/jni-rs/blob/master/CHANGELOG.md) - [Commits](jni-rs/jni-rs@v0.21.1...v0.22.4) --- updated-dependencies: - dependency-name: jni dependency-version: 0.22.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix(ui-android): migrate to jni 0.22 Behaviour-preserving migration accompanying the dependabot bump: JValueGen and generic GlobalRef reshapes, JObject::from_raw taking env, JNI_OnLoad on FFI-safe raw types, and compatibility push/pop_local_frame helpers over JNI v1.2's raw frame functions so every existing frame push capacity, pop location and branch path stays one-for-one. Thread attachment remains permanent with the former pending-exception policy. Runtime behaviour under ART is not verifiable off-device; the migration is compile-verified against aarch64-linux-android with -D warnings clean. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ralph Küpper <ralph@skelpo.com>
|
Landed via #9476 — your bump plus the code migration it needed. The full story is on that PR: the bump alone fails the Android cross-check with 1,601 errors, and the migration preserves the crate's JNI frame discipline one-for-one (233→234 pop lines, the delta being the new compatibility helper's definition). Compile-verified against |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps jni from 0.21.1 to 0.22.4.
Release notes
Sourced from jni's releases.
... (truncated)
Changelog
Sourced from jni's changelog.
... (truncated)
Commits
5ae9458Release jni 0.22.42f954cdFix copy&paste error s/JString::collection/JString::as_char_sequence/33045a1Release jni-macros 0.22.4527703eNo longer recommend passing&mut Envas the last argumentce7130bImport docs/macros/jni_mangle.md docs for jni_mangle macrod80bf23Add more-ergonomic JValueOwned accessors5ffd96abind_java_type: Support #[cfg()] guarded methods/fieldsb498e9fbind_java_type: support non_null methods/fields1f74e4bAddobjects::JCharSequencebinding25f810dRelease jni 0.22.3