test(drizzle): restore typed mysql2 dispatch - #9560
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Drizzle MySQL2 release fixture documents GC-scavenge and typed dispatch coverage. It removes explicit ChangesDrizzle MySQL2 typed fixture
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change restores typed MySQL2 dispatch coverage in an existing test fixture without changing production behavior, interfaces, or deployment configuration. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description provides the change summary, issue reference, test commands, known pre-tag-check limitation, and version-bump status. It omits some template headings, but the required information is substantially present. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
anyescape hatches from the existing Drizzle/MySQL2 transaction fixturedb.executeand the transaction callback through Drizzle's inferredMySql2Database<TSchema> & { $client: ... }typeCloses #9516.
Testing
bash tests/release/packages/drizzle-mysql2-tx/fixture.shwith the configured MySQL test credentials (PASS drizzle-mysql2-tx, 400 transactions, 1 MB nursery)cargo fmt --all --check./scripts/test_affected_crates.sh --base origin/main --dry-run./scripts/pre-tag-check.sh --quickpasses its other checks but currently reports the existing local-binding allowlist mismatch in untouched code (dispatch_receiver_class.rsversusdynamic_dispatch.rs).No version bump.
Summary by CodeRabbit