feat(codegen): resume completed LLVM units after interrupted builds - #9997
proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
(cherry picked from commit 72f1bb1)
|
Landed via #10001 (rebase train; author commits retained). Audited head: |
Change
Atomically checkpoint completed native units under the driver's full object-cache identity and a fingerprint of each frozen LLVM input. Treat missing, truncated, corrupt or unwritable records as cache misses.
Independent regression
Unit tests cover input isolation, corruption, nesting, unwinding and best-effort writes. Bounded CLI regression removes one of four completed units and the final module object, then requires 3 reused/1 rebuilt and byte-identical cold/resumed/uncached objects.
The branch starts directly from main and contains its own synthetic fixtures. No proprietary application sources, credentials, account or investigation artifacts are needed.
Validation completed
All four checkpoint unit tests passed. The bounded native driver proved 3 reused units/1 regenerated unit and identical cold/resumed/uncached objects. On unchanged main it found 0 of the required 4 checkpoints.
For transparency: the local before/after native and unit validation used main
8d88e481cand an integration checkout containing the nine audited patches together. Compiler and all nine runtime/extension archives had matching source identities. Each published branch is separate and passes its own CI warnings/check compilation jobs.Local gate run: all applicable script gates passed except the already-stale public benchmark artifact; product/host warnings and Clippy passed. The all-in-one run reached its 10-minute cap in the API-doc rebuild; both API outputs were then independently verified byte-for-byte with the matching built compiler (no drift).
Existing CI failures / landing note
typed_feedbacktest race encountered by the scoped codegen suites is fixed separately in test(codegen): isolate the default feedback lane #9999. Please include that test-only fix in the landing batch.Ready for the maintainer landing workflow. The full application will be rebuilt only after the required production changes are verified on main.