Add option to choose boost filesystem over std filesystem - #6005
Merged
Conversation
Currently, std filesystem is chosen if it is available (if compiled as C++17 or higher). However, it might be good to have the option to choose boost filesystem over std filesystem, even if the latter is available, in case there is some problem with std filesystem.
Contributor
|
Could we make a nice cmake option to enable this? |
larshg
approved these changes
Apr 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, std filesystem is chosen if it is available (if compiled as C++17 or higher). However, it might be good to have the option to choose boost filesystem over std filesystem, even if the latter is available, in case there is some problem with std filesystem.
With this commit, std filesystem is still used if available, unless the user has defined the preprocessor symbol
PCL_PREFER_BOOST_FILESYSTEM