Skip to content

feat: add optional strategy and terminationGracePeriodSeconds to gateway deployment #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avaya09 merged 1 commit into from
Feb 20, 2026
Merged

feat: add optional strategy and terminationGracePeriodSeconds to gateway deployment #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/portkey-gateway/templates/gateway/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ spec:
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
{{- end }}
{{- with .Values.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
{{- end }}
selector:
matchLabels:
{{- include "portkeyenterprise.selectorLabels" . | nindent 6 }}
Expand All @@ -39,6 +43,9 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
{{- if .Values.terminationGracePeriodSeconds }}

Copilot AI Feb 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional check {{- if .Values.terminationGracePeriodSeconds }} will evaluate to false when the value is 0, which is a valid Kubernetes value meaning "delete immediately". This prevents users from explicitly setting terminationGracePeriodSeconds to 0. Consider using a more specific check like {{- if ne .Values.terminationGracePeriodSeconds nil }} or {{- if hasKey .Values "terminationGracePeriodSeconds" }} to allow 0 as a valid value.

Suggested change
{{- if .Values.terminationGracePeriodSeconds }}
{{- if ne .Values.terminationGracePeriodSeconds nil }}

Copilot uses AI. Check for mistakes.
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
imagePullSecrets:
{{- range .Values.imageCredentials }}
- name: {{ .name }}
Expand Down
13 changes: 13 additions & 0 deletions charts/portkey-gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@

replicaCount: 1

# Deployment strategy configuration
# Example:
# strategy:
# type: RollingUpdate
# rollingUpdate:
# maxSurge: 1
# maxUnavailable: 0
strategy: {}

images:
gatewayImage:
repository: "docker.io/portkeyai/gateway_enterprise"
Expand Down Expand Up @@ -265,6 +274,10 @@ hostAlias: []
# if you want to restart instance automatically
autoRestart: false

# Optional: Grace period for pod termination (in seconds)

Copilot AI Feb 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment includes "Optional:" prefix which is inconsistent with other similar optional configuration fields in this file (e.g., strategy, hostAlias). Consider removing "Optional:" to maintain consistency with the established commenting style: "Grace period for pod termination (in seconds)".

Suggested change
# Optional: Grace period for pod termination (in seconds)
# Grace period for pod termination (in seconds)

Copilot uses AI. Check for mistakes.
# terminationGracePeriodSeconds: 30
terminationGracePeriodSeconds:


dataservice:
name: "dataservice"
Expand Down