Skip to content
This repository was archived by the owner on Nov 4, 2021. It is now read-only.

Benchmarks & various changes - #41

Merged
Twixes merged 22 commits into
masterfrom
benchmarks
Dec 8, 2020
Merged

Benchmarks & various changes#41
Twixes merged 22 commits into
masterfrom
benchmarks

Conversation

@mariusandra

Copy link
Copy Markdown
Collaborator
  • Add tasks per worker setting
  • Fix some test deprecation warnings
  • Make the benchmark test print graphs
  • Add two more types of benchmarks

Depends on #40

@mariusandra
mariusandra requested a review from Twixes December 7, 2020 17:05
Base automatically changed from tests-folder to master December 8, 2020 08:11
@mariusandra

Copy link
Copy Markdown
Collaborator Author

Also added:

  • Better handling of CLI arguments (directly created from the defaultConfig)
  • Renamed piscina.test.ts to worker.test.ts
  • Exit server if can't connect to redis
  • Add __jestSetTimeout inside VM when testing with jest to simulate requests
  • Add a simple option to set the log level in order to have less noisy tests
  • Chunk test events into batches of 100 for better async. (Waiting for 100 promises 10 times is better than waiting for 10k promises 1 time)

Can be reviewed!

@mariusandra mariusandra changed the title Benchmarks Benchmarks & various changes Dec 8, 2020
Comment thread .eslintrc.js Outdated
Comment thread src/config.ts Outdated
Comment thread src/index.ts Outdated
Comment thread src/types.ts Outdated
Comment thread tests/worker.test.ts Outdated
@mariusandra
mariusandra requested a review from Twixes December 8, 2020 10:55
@Twixes
Twixes merged commit 7a2ccd5 into master Dec 8, 2020
@Twixes
Twixes deleted the benchmarks branch December 8, 2020 11:42
fuziontech pushed a commit to PostHog/posthog that referenced this pull request Oct 12, 2021
…Hog/benchmarks

Benchmarks & various changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants