This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Mostly remove processEventBatch - #442
Merged
Merged
Conversation
mariusandra
marked this pull request as draft
May 27, 2021 22:26
mariusandra
marked this pull request as ready for review
May 28, 2021 07:48
Twixes
approved these changes
May 28, 2021
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
…ver#442) * mostly remove processEventBatch * fix issues * fix bug, remove dead test code * add verbosity to posthog/master dist github CI task * fix quotes * fix test * more ci verbosity * rename file * quotes really are important :) * give the plugin server time to shut down before displaying the full log * Remove now redundant test Co-authored-by: Michael Matloka <dev@twixes.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
processEventBatchdead code, which wasn't called.processEventBatchcode left is inside the VM, where we have aif (!processEvent && processEventBatch) { processEvent = event => processEventBatch([event]) }code in place.Checklist